-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin panics when running in multiple containers #3189
Comments
I have the same problem, although not using Swarm. I can easily reproduce on a clean Docker install and starting multiple containers using Loki logging plugin driver. It seems to be caused by a dual registration inside the Prometheus client:
|
Issue seems to be caused by 628c1fa |
Confirmed that rolling back the plugin to prior commit 54d1d3b resolved the issue for me, |
Thanks @patrickmglynn , ran into the same issue and as you mentioned the prior commit worked for me as well |
Have some problem and need to check status loki.
Why twice? I do not know, but the first start after: |
I think it's more related to the loki plugin version than Docker version, as I have the same behaviour with a fresh install of Docker 19.03.14. Reverting to commit 54d1d3b fixed:
|
@patrickmglynn why did you close this issue? I believe the issue hasn’t been patched, or am I mistaken? |
@patrickmglynn maybe you can change the issue title to better reflect the source of the problem. Something along the lines of": "Plugin panics when running in multiple containers" |
This is fixed in master. Isn't it ? I've sent a PR to fix it recently |
@cyriltovena I tested master today and worked perfectly. |
* Turn memcached circuit-breaker on by default Will trip after 10 failures within 10 seconds Signed-off-by: Bryan Boreham <[email protected]> * Change circuit-breaker log fields to avoid clash The names 'from' and 'to' are used elsewhere as dates, so avoid re-using them here as strings Signed-off-by: Bryan Boreham <[email protected]> * Update CHANGELOG Signed-off-by: Bryan Boreham <[email protected]> * Updated doc Signed-off-by: Marco Pracucci <[email protected]> Co-authored-by: Marco Pracucci <[email protected]>
…3190) * Turn memcached circuit-breaker on by default Will trip after 10 failures within 10 seconds Signed-off-by: Bryan Boreham <[email protected]> * Change circuit-breaker log fields to avoid clash The names 'from' and 'to' are used elsewhere as dates, so avoid re-using them here as strings Signed-off-by: Bryan Boreham <[email protected]> * Update CHANGELOG Signed-off-by: Bryan Boreham <[email protected]> * Updated doc Signed-off-by: Marco Pracucci <[email protected]> Co-authored-by: Marco Pracucci <[email protected]> Co-authored-by: Bryan Boreham <[email protected]>
Describe the bug
After upgrading to the latest Docker version, I now receive an "Unable to connect to plugin" message from Loki in the dockerd logs. As a result logs no longer push from Swarm services into my Loki instance.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Logs pushing to Loki instance from services running in Swarm.
Environment:
Screenshots, Promtail config, or terminal output
The offending log lines output from running journalctl -xe are included below:
Further detail about the logging driver plugin:
Additional troubleshooting steps
I have cleaned up unused networks/images etc. with
docker system prune -f
and have uninstalled and re-installed the Loki plugin.The text was updated successfully, but these errors were encountered: