Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos within Mixin Dasboards. #2666

Closed
Whyeasy opened this issue Sep 24, 2020 · 1 comment
Closed

Typos within Mixin Dasboards. #2666

Whyeasy opened this issue Sep 24, 2020 · 1 comment
Labels
stale A stale issue or PR that will automatically be closed.

Comments

@Whyeasy
Copy link
Contributor

Whyeasy commented Sep 24, 2020

Describe the bug

Within the Loki-Mixin and 'Promtail-Mixin` dashboards I think I found some typos. I'm fine to create the PR, but just wanted to double check if they are indeed typos.

dashboards['loki-reads.json'].matchers.querier + [utils.selector.re('route', grpc_routes)],

I guess .matchers.querier should be .matchers.ingester?

g.qpsPanel('promtail_request_duration_seconds_count{%s}')

Is missing the % dashboards['promtail.json'].selector.

To Reproduce
Steps to reproduce the behavior:

  1. Generate the dashboards.
  2. Promtail dashboard will show the error: Parse error: unexpected character inside braces: %
  3. In the Loki Reads dashboard the Ingester Latency will show the same data as the Querier Latency, but the Ingester has it's own metrics for this panel.

Expected behavior
The Promtail dashboard will show the data instead of the error and the Loki Read dashboard will show the correct data.

Environment:

  • Infrastructure: Kubernetes
  • Deployment tool: jsonnet.
@stale
Copy link

stale bot commented Oct 24, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Oct 24, 2020
@stale stale bot closed this as completed Nov 1, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this issue Jun 11, 2021
…assandra. (grafana#2666)

* Allow users to configure the number of TCP connections per host for Cassandra.

Signed-off-by: Tom Wilkie <[email protected]>

* Update docs.

Signed-off-by: Tom Wilkie <[email protected]>

* Use flagext.DefaultValues in Cassandra fixtures.

Signed-off-by: Tom Wilkie <[email protected]>

* Use separate sessions for reads and write in Cassandra.

Signed-off-by: Tom Wilkie <[email protected]>

* Add changelog entries.

Signed-off-by: Tom Wilkie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale A stale issue or PR that will automatically be closed.
Projects
None yet
Development

No branches or pull requests

1 participant