Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust loki_ingester_chunk_compression_ratio to better report compression ratio #1138

Closed
joe-elliott opened this issue Oct 9, 2019 · 0 comments · Fixed by #1143
Closed

Adjust loki_ingester_chunk_compression_ratio to better report compression ratio #1138

joe-elliott opened this issue Oct 9, 2019 · 0 comments · Fixed by #1143
Assignees
@joe-elliott
Labels
good first issue These are great first issues. If you are looking for a place to start, start here!

Comments

@joe-elliott
Copy link
Member

Currently loki_ingester_chunk_compression_ratio (https://github.com/grafana/loki/blob/master/pkg/ingester/flush.go#L44) has poorly defined histogram buckets.

The 90th percentile will often be artificially capped at 8.5 (the largest bucket value). Additionally it will might be nice to have more vision <1. Through experimentation determine and configure a better set of buckets.
@joe-elliott joe-elliott added hacktoberfest good first issue These are great first issues. If you are looking for a place to start, start here! labels Oct 9, 2019
@joe-elliott joe-elliott self-assigned this Oct 11, 2019
@joe-elliott joe-elliott mentioned this issue Oct 11, 2019
Merged
cyriltovena pushed a commit to cyriltovena/loki that referenced this issue Jun 11, 2021
@tomwilkie
Merge pull request grafana#1138 from gouthamve/up-max-size
07573ab 
Make the max grpc receive message size configurable, in Bigtable client
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joe-elliott joe-elliott

Labels
good first issue These are great first issues. If you are looking for a place to start, start here!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved compression ratio histogram joe-elliott/loki
1 participant
@joe-elliott