Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved validators for OpenCost prometheus URLs and basic auth #1012

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

petewall
Copy link
Collaborator

Fixes #1005

Signed-off-by: Pete Wall <[email protected]>
@petewall petewall requested review from rlankfo and skl December 18, 2024 23:45
Copy link
Member

@skl skl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@petewall petewall merged commit 11368f6 into main Dec 19, 2024
25 checks passed
@petewall petewall deleted the fix/validators branch December 19, 2024 14:26
bentonam pushed a commit that referenced this pull request Dec 19, 2024
* Improved validators for OpenCost prometheus URLs and basic auth

Signed-off-by: Pete Wall <[email protected]>

* Sync the helpers template

Signed-off-by: Pete Wall <[email protected]>

---------

Signed-off-by: Pete Wall <[email protected]>
bentonam added a commit that referenced this pull request Dec 19, 2024
* Additional Cluster Events Processing

- Extracted default values from Cluster Events using logfmt
- Added static label source=kubernetes-events
- Added labelsToKeep support
- Added structuredMetadata support

* Normalized extraLogProcessingStages

Changed extraProcessingStages to extraLogProcessingStages for consistency across charts

* Additional Cluster Events Processing

- Extracted all systemd unit service discovery labels
- Added static label source=journal
- Added labelsToKeep support
- Added structuredMetadata support
- Determine log level

* Fixed Cluster Events Test and Rebuilt

* Add the ability to use a caFile in tls sections (#1013)

Signed-off-by: Pete Wall <[email protected]>

* Improved validators for OpenCost prometheus URLs and basic auth (#1012)

* Improved validators for OpenCost prometheus URLs and basic auth

Signed-off-by: Pete Wall <[email protected]>

* Sync the helpers template

Signed-off-by: Pete Wall <[email protected]>

---------

Signed-off-by: Pete Wall <[email protected]>

* Additional Cluster Events Processing

- Extracted default values from Cluster Events using logfmt
- Added static label source=kubernetes-events
- Added labelsToKeep support
- Added structuredMetadata support

* Sync'd and Rebuilt

* Scyn'd and Rebuilt

* Resolved Conflicts

* Regenerated Cluster Events Documentation

* Fixed Documentation and Unit Test

---------

Signed-off-by: Pete Wall <[email protected]>
Co-authored-by: Pete Wall <[email protected]>
bentonam pushed a commit that referenced this pull request Dec 19, 2024
* Improved validators for OpenCost prometheus URLs and basic auth

Signed-off-by: Pete Wall <[email protected]>

* Sync the helpers template

Signed-off-by: Pete Wall <[email protected]>

---------

Signed-off-by: Pete Wall <[email protected]>
bentonam added a commit that referenced this pull request Dec 19, 2024
* Additional Cluster Events Processing

- Extracted default values from Cluster Events using logfmt
- Added static label source=kubernetes-events
- Added labelsToKeep support
- Added structuredMetadata support

* Normalized extraLogProcessingStages

Changed extraProcessingStages to extraLogProcessingStages for consistency across charts

* Additional Cluster Events Processing

- Extracted all systemd unit service discovery labels
- Added static label source=journal
- Added labelsToKeep support
- Added structuredMetadata support
- Determine log level

* Fixed Cluster Events Test and Rebuilt

* Add the ability to use a caFile in tls sections (#1013)

Signed-off-by: Pete Wall <[email protected]>

* Improved validators for OpenCost prometheus URLs and basic auth (#1012)

* Improved validators for OpenCost prometheus URLs and basic auth

Signed-off-by: Pete Wall <[email protected]>

* Sync the helpers template

Signed-off-by: Pete Wall <[email protected]>

---------

Signed-off-by: Pete Wall <[email protected]>

* Additional Cluster Events Processing

- Extracted default values from Cluster Events using logfmt
- Added static label source=kubernetes-events
- Added labelsToKeep support
- Added structuredMetadata support

* Sync'd and Rebuilt

* Scyn'd and Rebuilt

* Resolved Conflicts

* Regenerated Cluster Events Documentation

* Fixed Documentation and Unit Test

---------

Signed-off-by: Pete Wall <[email protected]>
Co-authored-by: Pete Wall <[email protected]>
bentonam added a commit that referenced this pull request Dec 19, 2024
* Updated Integration Values Schema

* Added Loki Integration

* Exposed pod labels/annotations to loki.process

* Updated Integration Contribution Documentation

* Ensure structuredMetadata object is populated

* Added empty-lines rule

* Added Structured Metadata Support for Pod Logs

* Updated Examples and Tests

* Rebuilt chart

* Update charts/feature-integrations/values.yaml

Co-authored-by: Pete Wall <[email protected]>

* Update charts/feature-integrations/integrations/cert-manager-values.yaml

Co-authored-by: Pete Wall <[email protected]>

* Update charts/feature-integrations/integrations/cert-manager-values.yaml

Co-authored-by: Pete Wall <[email protected]>

* Added kubeDNS schema override

* Rebuilt Chart

* Added Meta-Monitoring Example

* Fixed Cert Manager Integration Test

* Moved labelSelectors to root

* Added Loki Integration Test

* Updated Docs

* Fixed Integration Test Query

* Rebuild

* [dependency] Update dependency "prometheus-operator-crds" for Helm chart "feature-prometheus-operator-objects" to 17.0.1 (#1007)

Signed-off-by: Pete Wall <[email protected]>
Co-authored-by: petewall <[email protected]>

* [dependency] Update dependency "prometheus-operator-crds" for Helm chart "k8s-monitoring-v1" to 17.0.1 (#1008)

Signed-off-by: Pete Wall <[email protected]>
Co-authored-by: petewall <[email protected]>

* Add the ability to use a caFile in tls sections (#1013)

Signed-off-by: Pete Wall <[email protected]>

* Improved validators for OpenCost prometheus URLs and basic auth (#1012)

* Improved validators for OpenCost prometheus URLs and basic auth

Signed-off-by: Pete Wall <[email protected]>

* Sync the helpers template

Signed-off-by: Pete Wall <[email protected]>

---------

Signed-off-by: Pete Wall <[email protected]>

* Cluster Events and Node Log Updates (#1016)

* Additional Cluster Events Processing

- Extracted default values from Cluster Events using logfmt
- Added static label source=kubernetes-events
- Added labelsToKeep support
- Added structuredMetadata support

* Normalized extraLogProcessingStages

Changed extraProcessingStages to extraLogProcessingStages for consistency across charts

* Additional Cluster Events Processing

- Extracted all systemd unit service discovery labels
- Added static label source=journal
- Added labelsToKeep support
- Added structuredMetadata support
- Determine log level

* Fixed Cluster Events Test and Rebuilt

* Add the ability to use a caFile in tls sections (#1013)

Signed-off-by: Pete Wall <[email protected]>

* Improved validators for OpenCost prometheus URLs and basic auth (#1012)

* Improved validators for OpenCost prometheus URLs and basic auth

Signed-off-by: Pete Wall <[email protected]>

* Sync the helpers template

Signed-off-by: Pete Wall <[email protected]>

---------

Signed-off-by: Pete Wall <[email protected]>

* Additional Cluster Events Processing

- Extracted default values from Cluster Events using logfmt
- Added static label source=kubernetes-events
- Added labelsToKeep support
- Added structuredMetadata support

* Sync'd and Rebuilt

* Scyn'd and Rebuilt

* Resolved Conflicts

* Regenerated Cluster Events Documentation

* Fixed Documentation and Unit Test

---------

Signed-off-by: Pete Wall <[email protected]>
Co-authored-by: Pete Wall <[email protected]>

* Updated Integration Values Schema

* Updated Examples and Tests

* Moved labelSelectors to root

* Sync'd Changes and Rebuilt

* Updated Integration Values Schema

* Sync'd and Rebuilt

* Sync'd and Rebuilt

* Regenerated Documentation

* Regenerated

---------

Signed-off-by: Pete Wall <[email protected]>
Co-authored-by: Pete Wall <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: petewall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add check if basic auth is specified, but no username or password is set
2 participants