Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable console in the init context #982

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Mar 29, 2019

This commit does the bare minimal to enable useage of console init
context. Unfortunetely this means that redirection to file is currently
not supported in init context.

This fixes #951

Message for the release notes:

bugfix: console is now usable inside the init context. Unfortunately this doesn't respect --console-output (#1131) , and will be fixed in the future.

@mstoykov mstoykov requested a review from na-- March 29, 2019 08:27
@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #982 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
+ Coverage   72.12%   72.12%   +<.01%     
==========================================
  Files         131      131              
  Lines        9621     9622       +1     
==========================================
+ Hits         6939     6940       +1     
  Misses       2268     2268              
  Partials      414      414
Impacted Files Coverage Δ
js/bundle.go 83.45% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3506ee1...802f615. Read the comment docs.

@na-- na-- changed the title Enable console in init context fix #951 Enable console in the init context Apr 10, 2019
This commit does the bare minimal to enable useage of console init
context. Unfortunetely this means that redirection to file is currently
not supported in init context.
@mstoykov mstoykov force-pushed the fixConsoleInInitContext branch from 802f615 to 570fc36 Compare August 26, 2019 11:02
@codecov-io
Copy link

codecov-io commented Aug 26, 2019

Codecov Report

Merging #982 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
+ Coverage   73.28%   73.28%   +<.01%     
==========================================
  Files         141      141              
  Lines       10287    10288       +1     
==========================================
+ Hits         7539     7540       +1     
  Misses       2304     2304              
  Partials      444      444
Impacted Files Coverage Δ
js/bundle.go 82.67% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c202415...570fc36. Read the comment docs.

@na-- na-- added this to the v0.26.0 milestone Aug 29, 2019
@mstoykov mstoykov requested review from imiric and cuonglm August 29, 2019 10:08
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in #951 (comment), it'd be fine with merging this as it is for now, despite the known incompatibility with --console-output. But before merging it, we should create a new issue that describes this bug, linking to this PR and the original issue. And we should mention it in a Known bugs section in the release notes, so add that to the PR description please.

@mstoykov mstoykov merged commit 2326f04 into master Aug 29, 2019
@mstoykov mstoykov deleted the fixConsoleInInitContext branch August 29, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make console.log() available in the init context
4 participants