Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix k6packager workflow #4143

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix k6packager workflow #4143

merged 1 commit into from
Dec 20, 2024

Conversation

mstoykov
Copy link
Contributor

What?

Fix k6packager with similar problem to #3894

Why?

Not certain it actually needs to be rebuild every Sunday, but there is a chance this is a problem around #4142

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov requested a review from a team as a code owner December 20, 2024 09:25
@mstoykov mstoykov requested review from inancgumus and olegbespalov and removed request for a team December 20, 2024 09:25
@mstoykov mstoykov added the ci label Dec 20, 2024
joanlopez
joanlopez reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@joanlopez joanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change something so we get notified if this starts failing again? 🤔

@mstoykov mstoykov merged commit cf7a622 into master Dec 20, 2024
16 of 25 checks passed
@mstoykov mstoykov deleted the fixK6Packager branch December 20, 2024 09:29
@mstoykov mstoykov mentioned this pull request Dec 20, 2024
Open
mstoykov added a commit that referenced this pull request Jan 6, 2025
@mstoykov
release notes for #4143
df39442
ankur22 pushed a commit that referenced this pull request Jan 6, 2025
@mstoykov @ankur22
release notes for #4143
7f82677
ankur22 pushed a commit that referenced this pull request Jan 6, 2025
@mstoykov @ankur22
release notes for #4143
ed1f9df
@BrewTestBot BrewTestBot mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanlopez joanlopez joanlopez approved these changes

@olegbespalov olegbespalov olegbespalov approved these changes

@ankur22 ankur22 ankur22 approved these changes

@inancgumus inancgumus Awaiting requested review from inancgumus inancgumus is a code owner automatically assigned from grafana/k6-core

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mstoykov @ankur22 @olegbespalov @joanlopez