Add test for race in PushIfNotDone #4082
Closed
+36
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
oleiade and
olegbespalov
and removed request for
a team
olegbespalov
requested changes
Dec 9, 2024
|
This was a PR to illustrate that there is no way for the current PushIfNotDOne to not race with the context done and channel close. The thing is that in the current code there is no place where the channel gets closed before every VU has returned so nothing should be using this - which is signaled with the context close. The "real" fix for this will be to not use close the channel, but that is already used in some places, so it is way more involved. Again in practice this should never happen - if it does it is a bug in the other code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)