Use the precompiled 'gotip' on the xk6 workflow #4072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanlopez
commented
Nov 19, 2024
| @@ -17,20 +17,26 @@ jobs: | |||
| matrix: | |||
| go: [stable, tip] | |||
| platform: [ubuntu-latest, windows-2019, macos-latest] | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
Looks like we weren't using matrix.platform, so actually all the jobs were being executed on the same platform 😅
I realized it, because when I tried to use the precompiled Go tip, it complained because the binary wasn't in the expected platform (e.g. a binary built for Windows, trying to be executed on Ubuntu, in this case haha)
joanlopez
commented
Nov 19, 2024
| @@ -54,6 +60,13 @@ jobs: | |||
| "${{ github.event.pull_request.head.repo.full_name }}" != "${{ github.repository }}" ]; then | |||
| export XK6_K6_REPO="github.com/${{ github.event.pull_request.head.repo.full_name }}" | |||
| fi | |||
| # The following is a workaround for Windows, cause when using 'shell: bash', the PATH is expressed | |||
There was a problem hiding this comment.
Something I learned along the way, while working on this PR 💡
olegbespalov
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It updates the
xk6workflow to use the precompiled gotip, as we already do for theTestworkflow.Why?
Last week I realized that we aren't using it because the CI workflow failed due to 'https://go.googlesource.com/go/' returning
503 Service Unavailable(see here).This isn't a "perfect" solution for that situation, because I guess the GitHub APIs (Assets, in this case) could eventually go down, as the site where Google hosts code was in that case, but it speeds up the workflow and reuses what we're already using in other workflows as
Testor k6-ci , for the sake of consistency.Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)