Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k6-taskqueue-lib to a version without goja #4057

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Update k6-taskqueue-lib to a version without goja #4057

merged 1 commit into from
Nov 14, 2024

Conversation

mstoykov
Copy link
Contributor

What?

Update k6-taskqueue-lib

Why?

I noticed it still references old version of k6 in its test that depends on goja. This removes this.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.56.0 milestone Nov 14, 2024
@mstoykov mstoykov requested a review from a team as a code owner November 14, 2024 08:45
@mstoykov mstoykov requested review from inancgumus and joanlopez and removed request for a team November 14, 2024 08:45
@mstoykov mstoykov merged commit 607e5ad into master Nov 14, 2024
22 checks passed
@mstoykov mstoykov deleted the updateTaskQueue branch November 14, 2024 16:05
@BrewTestBot BrewTestBot mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanlopez joanlopez joanlopez approved these changes

@inancgumus inancgumus inancgumus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.56.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mstoykov @inancgumus @joanlopez