Replace strings.SplitN(2) with strings.Cut #4022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It updates the calls to
strings.SplitN
, withn=2
withstrings.Cut
, because most of the times that's whystrings.Cut
was added into the Go stdlib, as it makes the code involved more readable.Why?
I started with a single
// TODO
I found while working on another task, but then realized that the codebase is plenty of calls tostrings.SplitN
withn=2
, wheremostall the cases what we really want is to "cut" (split) a string containing key-values (e.g.key:value
,key=value
, etc).Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)