Introduce k6 cloud upload to replace --upload-only #3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joanlopez
commented
Aug 21, 2024
joanlopez
commented
Aug 21, 2024
5 tasks
olegbespalov
previously approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Nit: maybe you could consider switching the upload the test (in all places) to upload the test data or even upload the test scripts and resources. Perhaps it's just me, but upload the test sounds incomplete. Shrug: Anyway, for sure, this is a non-blocking thing.
codebien
requested changes
Aug 22, 2024
joanlopez
force-pushed
the
cloud_subcommands-upload
branch
from
c2f0c13 to
4bbc72f
Compare
codebien
approved these changes
Aug 26, 2024
olegbespalov
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It introduces a new cloud subcommand:
k6 cloud uploadto replace the oldk6 cloud --upload-only.It also marks the old flag as deprecated, so it is no longer displayed in help, and a deprecation message is displayed when used, as follows:
Flag --upload-only has been deprecated, use "k6 cloud upload" instead.Why?
As part of the task of revamping the k6 cloud commands.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
N/A