Update to [email protected]

[joanlopez]

What?

Updates to the latest version of xk6-websockets, which includes support for Blob.

See grafana/xk6-websockets#74 for further details.

Why?

Checklist

• I have performed a self-review of my code.
• I have added tests for my changes.
• I have run linter locally (make lint) and all checks pass.
• I have run tests locally (make tests) and all tests pass.
• I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Contributes to grafana/xk6-websockets#35

[joanlopez]

Open question: should we tag it as breaking-change?

In my opinion, even if it's kinda expected/permitted/accepted (because the module is experimental), it's nice to list it as part of the breaking changes within Release Notes, so users can easily notice it, but I'm not sure what we usually do in such cases.

The breaking change is that now we return an error if websocket.binaryType isn't defined (there was a warning before).

cc/ @mstoykov @codebien

[codebien]

In my opinion, even if it's kinda expected/permitted/accepted (because the module is experimental)

It remains a breaking change, and it still makes sense to announce it. IMHO, the experimental concept is something on top. In the event we were strictly following semver, the fact that the module is experimental just allows us to not bump a major version.

[joanlopez]

In my opinion, even if it's kinda expected/permitted/accepted (because the module is experimental)

It remains a breaking change, and it still makes sense to announce it. IMHO, the experimental concept is something on top. In the event we were strictly following semver, the fact that the module is experimental just allows us to not bump a major version.

I agree!