Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes after Sobek migration #3817

Merged
merged 2 commits into from
Jul 1, 2024
Merged

More fixes after Sobek migration #3817

merged 2 commits into from
Jul 1, 2024

Conversation

mstoykov
Copy link
Contributor

What?

Github workflows were not updated

Why?

It will be nice to run the test when Sobek is changed and we should probably up the version a little bit in the xk6 tests.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.53.0 milestone Jun 26, 2024
@mstoykov mstoykov requested a review from a team as a code owner June 26, 2024 15:45
@mstoykov mstoykov requested review from oleiade and joanlopez and removed request for a team June 26, 2024 15:45
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@d9b5fd0). Learn more about missing BASE report.

Current head 8a02ba6 differs from pull request most recent head 2e2aaef

Please upload reports for the commit 2e2aaef to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3817   +/-   ##
=========================================
  Coverage          ?   71.87%           
=========================================
  Files             ?      291           
  Lines             ?    21274           
  Branches          ?        0           
=========================================
  Hits              ?    15290           
  Misses            ?     4920           
  Partials          ?     1064           
Flag Coverage Δ
ubuntu 71.81% <ø> (?)
windows 71.73% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov mstoykov merged commit af5e9e7 into master Jul 1, 2024
22 checks passed
@mstoykov mstoykov deleted the moreSobekFixes branch July 1, 2024 08:41
@mstoykov mstoykov mentioned this pull request Jul 19, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants