-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop catching panics #3777
Stop catching panics #3777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Have you checked if some extension doesn't use it - maybe we can tell them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should add the breaking change label
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3777 +/- ##
==========================================
- Coverage 70.87% 70.77% -0.11%
==========================================
Files 291 289 -2
Lines 21227 21215 -12
==========================================
- Hits 15044 15014 -30
- Misses 5218 5230 +12
- Partials 965 971 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5389a22
dcf4b54
to
5389a22
Compare
A quick search shows that only forks, but I'll check better later on 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I did check through my https://github.com/mstoykov/xk6-extensions/tree/main/checkout-all-extensions as I was working around it either way - no usage were found.
What?
We stop catching the panic in k6.
Why?
Catching the panic could prevent us/customers from identifying them early. Instead, we should deliver the fixes for the panic cases.
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
Closes #3748