Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop old linter setting (GRPC's reflection) #3769

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

joanlopez
Copy link
Contributor

@joanlopez joanlopez commented Jun 5, 2024

What?

It removes an old linter setting, set for gRPC's reflection.

Why?

Because the issue used to track it was completed some months ago.
So, it should no longer be required, or we should re-open it create a new issue.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@joanlopez joanlopez requested a review from a team as a code owner June 5, 2024 06:35
@joanlopez joanlopez requested review from mstoykov and olegbespalov and removed request for a team June 5, 2024 06:35
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.80%. Comparing base (93649df) to head (c755f1c).

Current head c755f1c differs from pull request most recent head a53d946

Please upload reports for the commit a53d946 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3769      +/-   ##
==========================================
- Coverage   70.88%   70.80%   -0.08%     
==========================================
  Files         291      289       -2     
  Lines       21226    21221       -5     
==========================================
- Hits        15045    15026      -19     
- Misses       5216     5226      +10     
- Partials      965      969       +4     
Flag Coverage Δ
ubuntu 70.80% <ø> (-0.03%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joanlopez joanlopez merged commit 3fe2f14 into master Jun 5, 2024
22 checks passed
@joanlopez joanlopez deleted the drop-old-linter-setting branch June 5, 2024 07:26
@joanlopez joanlopez added this to the v0.52.0 milestone Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants