Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade xk6-dashboard to v0.7.3 #3752

Merged
merged 1 commit into from
May 23, 2024
Merged

feat: upgrade xk6-dashboard to v0.7.3 #3752

merged 1 commit into from
May 23, 2024

Conversation

szkiba
Copy link
Contributor

@szkiba szkiba commented May 22, 2024

What?

Upgrade xk6-dhasboard to v0.7.3

Why?

xk6-dashboard v0.7.3 release notes

Related Issue

#3613

@szkiba szkiba requested a review from a team as a code owner May 22, 2024 13:22
@szkiba szkiba requested review from mstoykov and oleiade and removed request for a team May 22, 2024 13:22
@szkiba szkiba linked an issue May 22, 2024 that may be closed by this pull request
upgrade xk6-dashboard to v0.7.3 #3613
Closed
@mstoykov mstoykov added breaking change for PRs that need to be mentioned in the breaking changes section of the release notes dependencies Pull requests that update a dependency file labels May 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.86%. Comparing base (f947acb) to head (994b61e).

❗ Current head 994b61e differs from pull request most recent head a37586f

Please upload reports for the commit a37586f to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3752      +/-   ##
==========================================
+ Coverage   70.84%   70.86%   +0.01%     
==========================================
  Files         289      289              
  Lines       21156    21156              
==========================================
+ Hits        14988    14992       +4     
+ Misses       5211     5207       -4     
  Partials      957      957
Flag Coverage Δ
ubuntu 70.80% <ø> (+0.02%) ⬆️
windows 70.71% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mstoykov
mstoykov approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably would've gotten for somethign that makes it more obvious the output from the extension is an extension as dashboard vs web-dashboard isn't particularly great IMO.

otherwise LGTM

@szkiba szkiba merged commit befc4d5 into master May 23, 2024
22 checks passed
@szkiba szkiba deleted the 3613-upgrade-xk6-dashboard-to-v0.7.3 branch May 23, 2024 14:49
@olegbespalov olegbespalov added this to the v0.52.0 milestone May 24, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiade oleiade oleiade approved these changes

@mstoykov mstoykov mstoykov approved these changes

Assignees
No one assigned
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v0.52.0
Development

Successfully merging this pull request may close these issues.

upgrade xk6-dashboard to v0.7.3
5 participants
@szkiba @codecov-commenter @mstoykov @oleiade @olegbespalov