Drop legacy require support #3694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
oleiade and
joanlopez
and removed request for
a team
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3694 +/- ##
==========================================
- Coverage 70.88% 70.87% -0.01%
==========================================
Files 291 288 -3
Lines 21226 21183 -43
==========================================
- Hits 15045 15013 -32
+ Misses 5216 5206 -10
+ Partials 965 964 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mstoykov
force-pushed
the
requireWarning
branch
from
872ce2c to
79d8dab
Compare
joanlopez
reviewed
Jun 3, 2024
| return r.modSys.Require(specifier) | ||
| } | ||
|
|
||
| // getPreviousRequiringFile is a helper that is currently need for the implemnetation of `open`. |
There was a problem hiding this comment.
Suggested change
| // getPreviousRequiringFile is a helper that is currently need for the implemnetation of `open`. | |
| // getPreviousRequiringFile is a helper that is currently need for the implementation of `open`. |
joanlopez
approved these changes
Jun 3, 2024
oleiade
approved these changes
Jun 12, 2024
|
This is now part of #3456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Completely drop the legacy require support
Why?
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)