-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added summary generated event #3682
Added summary generated event #3682
Conversation
Hey @ameetpal 👋🏻 First and foremost, thanks a lot for taking the time and putting the effort into contributing to k6, we very much appreciate it 🙇🏻 We had a bit of a delay in our response as the team needed to discuss and synchronize on this topic. We reached the conclusion that we're rather open to reviewing and potentially merging this, with the specific caveat that we consider this internal event system experimental, and we might change/break it and its API in the future. Thus, if that's an acceptable prerequisite for you, we'll go ahead with the review indeed 👍🏻 PS: through our discussions, we outlined that this could potentially be a topic/issue/PR that you would be interested in @pablochacin 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @oleiade , @olegbespalov , we are fine with the condition and we can go ahead and merge this |
This reverts commit eec9105.
This reverts commit eec9105.
What?
Emitting Summary Generated event
Why?
#3683
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)