Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'envconfig' to fix environment variables reads #3672

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

joanlopez
Copy link
Contributor

What?

It updates the envconfig dependency to include a recent fix to adequately support nil marshalable pointers,
which is causing #3638.

Why?

After having discarded #3660, we decided (see here and here) to just push the fix to our own fork of envconfig, for simplicity.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Closes #3638

@joanlopez joanlopez added the bug label Apr 4, 2024
@joanlopez joanlopez self-assigned this Apr 4, 2024
@joanlopez joanlopez requested a review from a team as a code owner April 4, 2024 07:36
@joanlopez joanlopez requested review from codebien, olegbespalov and mstoykov and removed request for a team April 4, 2024 07:36
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.60%. Comparing base (2af1a3f) to head (7258fc2).

❗ Current head 7258fc2 differs from pull request most recent head d182d5d. Consider uploading reports for the commit d182d5d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3672   +/-   ##
=======================================
  Coverage   73.60%   73.60%           
=======================================
  Files         277      277           
  Lines       20251    20251           
=======================================
  Hits        14906    14906           
- Misses       4399     4400    +1     
+ Partials      946      945    -1     
Flag Coverage Δ
ubuntu 73.54% <ø> (+0.01%) ⬆️
windows 73.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joanlopez joanlopez merged commit 61c7556 into master Apr 4, 2024
24 checks passed
@joanlopez joanlopez deleted the fix-3638-2 branch April 4, 2024 08:51
@olegbespalov olegbespalov added this to the v0.51.0 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K6_SYSTEM_TAGS environment variable not being read
5 participants