Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade xk6-dashboard to v0.7.3 #3614

Closed
wants to merge 1 commit into from
Closed

Conversation

szkiba
Copy link
Contributor

@szkiba szkiba commented Feb 26, 2024

What?

Upgrade xk6-dashboard dependency to v0.7.3

Release Notes v0.7.3

[WARNING!]
Attention, this is just a placeholder PR, it currently contains version v0.7.3-alpha.1. As soon as the final v0.7.3 version is ready, the PR will be updated.

Checklist

  • [x ] I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

@szkiba szkiba linked an issue Feb 26, 2024 that may be closed by this pull request
@szkiba szkiba requested a review from a team as a code owner February 26, 2024 17:23
@szkiba szkiba requested review from mstoykov and codebien and removed request for a team February 26, 2024 17:23
@codebien
Copy link
Contributor

Attention, this is just a placeholder PR

@szkiba Does it mean we don't have to review it? If yes, can you convert it into a draft PR, please?

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.57%. Comparing base (b5a6feb) to head (56ef773).

❗ Current head 56ef773 differs from pull request most recent head 158382f. Consider uploading reports for the commit 158382f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3614      +/-   ##
==========================================
+ Coverage   73.55%   73.57%   +0.01%     
==========================================
  Files         277      277              
  Lines       20228    20228              
==========================================
+ Hits        14879    14883       +4     
+ Misses       4401     4397       -4     
  Partials      948      948              
Flag Coverage Δ
macos ?
ubuntu 73.53% <ø> (+0.05%) ⬆️
windows 73.42% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szkiba szkiba marked this pull request as draft February 26, 2024 17:34
@szkiba
Copy link
Contributor Author

szkiba commented Feb 26, 2024

Attention, this is just a placeholder PR

@szkiba Does it mean we don't have to review it? If yes, can you convert it into a draft PR, please?

@codebien done

it probably doesn't require a big review, but I wouldn't say it doesn't require a review, so converted to draft

@codebien codebien removed their request for review March 19, 2024 10:41
@szkiba
Copy link
Contributor Author

szkiba commented May 22, 2024

It's been open for too long, it's easier to open a new PR.

@szkiba szkiba closed this May 22, 2024
@szkiba szkiba deleted the feat/xk6-dashboard-v0.7.3 branch May 30, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants