Erroring if gRPC parameters contains headers key #3350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #2371 we deprecated the
headers
param in favor ofmetadata
.k6/js/modules/k6/grpc/client.go
Lines 449 to 452 in 1892f91
Since it seems like a long time passed, we could finally remove the support of the
headers
.And as the first step, we could start erroring if the
headers
param is presented.Once this PR is merged, I'll open the PR with the far-away milestone to clean the error advising the use of
metadata
.Why?
We should clean up the
headers
Changelog
Minor breaking change: Previously, gRPC invoke's
headers
param was deprecated and fell through to themetadata
. Since this version of k6, using theheaders
param will result in an error. Instead, users should use themetadata
param.Checklist
make ci-like-lint
), and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
#3343 (comment)