dockerfile: Drop K6_BROWSER_ENABLED env #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3324 +/- ##
==========================================
- Coverage 73.20% 73.14% -0.06%
==========================================
Files 258 256 -2
Lines 19895 19890 -5
==========================================
- Hits 14564 14549 -15
- Misses 4406 4411 +5
- Partials 925 930 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
codebien
requested review from
a team,
mstoykov,
oleiade and
olegbespalov
and removed request for
a team and
oleiade
olegbespalov
approved these changes
Sep 7, 2023
mstoykov
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Drop
K6_BROWSER_ENABLEDfrom the Dockerfile to be consistent with the change documented here #3235.Why?
#3235 (comment) already applied it, but for some reason which I'm not able to get we lost it.