Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update goja to fix compiler bug #3308

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Update goja to fix compiler bug #3308

merged 1 commit into from
Aug 29, 2023

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Aug 29, 2023 •
edited
Loading

Original issue

Changelog

bug: Update goja to fix a compiler bug around classes that was found around the winston npm package.

@mstoykov mstoykov added this to the v0.47.0 milestone Aug 29, 2023
olegbespalov
olegbespalov approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For history and faster down-tracking, let's at least cross-reference the original issue or PR about the bug.

@mstoykov mstoykov merged commit fc1900e into master Aug 29, 2023
@mstoykov mstoykov deleted the updateGoja branch August 29, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegbespalov olegbespalov olegbespalov approved these changes

@codebien codebien codebien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.47.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mstoykov @codebien @olegbespalov