Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-template: Fix relative links #3291

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Aug 21, 2023

It fixes the relative links for the release notes item of the release template.

An example: #3274

@codebien codebien added this to the v0.47.0 milestone Aug 21, 2023
@codebien codebien requested a review from oleiade August 21, 2023 09:52
@codebien codebien self-assigned this Aug 21, 2023
Copy link
Member

@oleiade oleiade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arf, sorry rebase mishap 🤦🏻 Thanks for fixing it 👍🏻

@codebien codebien requested review from a team and olegbespalov and removed request for a team August 21, 2023 09:59
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #3291 (3825972) into master (4ad625c) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 3825972 differs from pull request most recent head 03be13c. Consider uploading reports for the commit 03be13c to get more accurate results

@@           Coverage Diff           @@
##           master    #3291   +/-   ##
=======================================
  Coverage   73.21%   73.21%           
=======================================
  Files         258      258           
  Lines       19884    19884           
=======================================
+ Hits        14558    14559    +1     
  Misses       4402     4402           
+ Partials      924      923    -1     
Flag Coverage Δ
ubuntu 73.16% <ø> (+0.01%) ⬆️
windows 73.06% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@codebien codebien merged commit 63a1fdd into master Aug 21, 2023
21 checks passed
@codebien codebien deleted the fix-release-issue-notes-links branch August 21, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants