Remove K6_BROWSER_ENABLED flag requirement

[ka3de]

What?

Removes the requirement for the K6_BROWSER_ENABLED environment variable in order to execute tests that use the experimental browser module.

Why?

Currently (as of grafana/xk6-browser@a8ebe8c) the browser extension requires the definition of the browser type parameter inside the options element for every scenario that wants to use the browser module. Therefore the usage of K6_BROWSER_ENABLED flag as an explicit approval to use the browser module has become redundant, as both parameters have to be set, being the scenario one more restrictive.

Checklist

• I have performed a self-review of my code.
• I have added tests for my changes. (N/A)
• I have run linter locally (make ci-like-lint) and all checks pass.
• I have run tests locally (make tests) and all tests pass.
• I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Closes #3197

[codecov-commenter]

Codecov Report

Merging #3221 (812d0ed) into master (703970e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 812d0ed differs from pull request most recent head 162b827. Consider uploading reports for the commit 162b827 to get more accurate results

@@            Coverage Diff             @@
##           master    #3221      +/-   ##
==========================================
- Coverage   72.68%   72.67%   -0.02%     
==========================================
  Files         259      258       -1     
  Lines       19864    19849      -15     
==========================================
- Hits        14439    14425      -14     
  Misses       4521     4521              
+ Partials      904      903       -1     

Flag	Coverage Δ
ubuntu	72.61% <100.00%> (-0.02%)	⬇️
windows	72.51% <100.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
js/jsmodules.go	100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

[ankur22]

Thanks for this 👍

I think we can remove the whole of the experimental/browser/rootmodule.go directory and file. We should be able to directly work with the root module that we define in the browser module -- replace "github.com/grafana/xk6-browser/browser" in jsmodules.go.

We created the RootModule wrapper in the experimental/browser pkg in k6 to enable us to work with the env var.

[ka3de]

We should be able to directly work with the root module that we define in the browser module -- replace "github.com/grafana/xk6-browser/browser" in jsmodules.go.

Right, thanks for the heads up, I think that makes sense, as I see there are other examples of using the external implementation directly. Let me address this.

[mstoykov]

Shouldn't this be merged after we update xk6-browser in k6?

[ka3de]

Shouldn't this be merged after we update xk6-browser in k6?

Right, I was assuming we will upgrade the current xk6-browser version, which release is planned for this Friday, at some point before the next k6 release. But yes, in practice we can wait for this to happen before merging this PR.

[ka3de]

Closing as superseded by #3235.