Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release checklist #3135

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Release checklist #3135

merged 4 commits into from
Jun 26, 2023

Conversation

codebien
Copy link
Contributor

It adds a checklist for driving a new release.

@codebien codebien self-assigned this Jun 23, 2023
@olegbespalov
Copy link
Contributor

Added two things that I think should be also here. Generally LGTM 👍 But maybe @mstoykov has something to add since he has used the checklist recently, so the final decision postpone for him 👍

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Merging #3135 (79af51b) into master (9fdd569) will decrease coverage by 1.89%.
The diff coverage is 33.94%.

❗ Current head 79af51b differs from pull request most recent head 0318c1c. Consider uploading reports for the commit 0318c1c to get more accurate results

@@            Coverage Diff             @@
##           master    #3135      +/-   ##
==========================================
- Coverage   73.88%   72.00%   -1.89%     
==========================================
  Files         243      252       +9     
  Lines       18488    19405     +917     
==========================================
+ Hits        13660    13972     +312     
- Misses       3961     4540     +579     
- Partials      867      893      +26     
Flag Coverage Δ
ubuntu 71.92% <33.94%> (-1.90%) ⬇️
windows 71.84% <33.94%> (-1.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
output/cloud/expv2/output.go 66.01% <5.12%> (-20.83%) ⬇️
cloudapi/insights/proto/v1/common/common.pb.go 15.20% <15.20%> (ø)
cloudapi/insights/proto/v1/ingester/ingester.pb.go 22.99% <22.99%> (ø)
cloudapi/insights/proto/v1/trace/span.pb.go 25.80% <25.80%> (ø)
...api/insights/proto/v1/ingester/ingester_grpc.pb.go 27.02% <27.02%> (ø)
cloudapi/insights/proto/v1/k6/labels.pb.go 27.47% <27.47%> (ø)
cloudapi/insights/proto/v1/trace/labels.pb.go 32.25% <32.25%> (ø)
...oudapi/insights/proto/v1/k6/request_metadata.pb.go 32.85% <32.85%> (ø)
cloudapi/insights/client.go 68.11% <68.11%> (ø)
cloudapi/insights/mappers.go 82.85% <82.85%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

olegbespalov
olegbespalov previously approved these changes Jun 23, 2023
@codebien
Copy link
Contributor Author

@olegbespalov I added the dependencies' bump inspired by your PR.

@codebien codebien requested review from oleiade and imiric June 23, 2023 11:27
release-notes-v04x <--- my-single-feature-notes-branch
```

- [ ] Go through the potential [dependencies updates](https://github.com/grafana/k6/blob/master/Dependencies.md) then create a PR if any is relevant.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind putting this as the responsibility of the release driver, but we should probably agree inside the team first that we put this onto the release driver person's shoulder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's use this PR to get the consensus. Are you (@grafana/k6-core) against moving here this responsibility?

.github/ISSUE_TEMPLATE/release.md Outdated Show resolved Hide resolved
@codebien
Copy link
Contributor Author

We are not including the action to open a milestone but I expect it is done most of the time during the previous cycle, so I think we may skip it. If have a different opinion let me know.

Copy link
Member

@oleiade oleiade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, much MUCH appreciated 🙇🏻 Thanks for doing this @codebien 👏🏻

@codebien codebien merged commit f2337a3 into master Jun 26, 2023
@codebien codebien deleted the release-template branch June 26, 2023 10:30
oleiade pushed a commit that referenced this pull request Jun 26, 2023
Release checklist

---------

Co-authored-by: Oleg Bespalov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants