-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release checklist #3135
Release checklist #3135
Conversation
be93350
to
ff60972
Compare
Added two things that I think should be also here. Generally LGTM 👍 But maybe @mstoykov has something to add since he has used the checklist recently, so the final decision postpone for him 👍 |
Co-authored-by: Oleg Bespalov <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3135 +/- ##
==========================================
- Coverage 73.88% 72.00% -1.89%
==========================================
Files 243 252 +9
Lines 18488 19405 +917
==========================================
+ Hits 13660 13972 +312
- Misses 3961 4540 +579
- Partials 867 893 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@olegbespalov I added the dependencies' bump inspired by your PR. |
.github/ISSUE_TEMPLATE/release.md
Outdated
release-notes-v04x <--- my-single-feature-notes-branch | ||
``` | ||
|
||
- [ ] Go through the potential [dependencies updates](https://github.com/grafana/k6/blob/master/Dependencies.md) then create a PR if any is relevant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind putting this as the responsibility of the release driver, but we should probably agree inside the team first that we put this onto the release driver person's shoulder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's use this PR to get the consensus. Are you (@grafana/k6-core) against moving here this responsibility?
We are not including the action to open a milestone but I expect it is done most of the time during the previous cycle, so I think we may skip it. If have a different opinion let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great, much MUCH appreciated 🙇🏻 Thanks for doing this @codebien 👏🏻
Release checklist --------- Co-authored-by: Oleg Bespalov <[email protected]>
It adds a checklist for driving a new release.