Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage report block of k6 execution if it takes longer than 3s #2938

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

na--
Copy link
Member

@na-- na-- commented Feb 25, 2023

This resolves #2937

@na-- na-- added the high prio label Feb 25, 2023
@na-- na-- added this to the v0.43.1 milestone Feb 25, 2023
@na-- na-- force-pushed the fix-blocking-usage-report branch from df6bcf5 to 1776af2 Compare February 25, 2023 09:29
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2023

Codecov Report

Merging #2938 (a3236cc) into master (2305316) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head a3236cc differs from pull request most recent head 15a2e28. Consider uploading reports for the commit 15a2e28 to get more accurate results

@@            Coverage Diff             @@
##           master    #2938      +/-   ##
==========================================
+ Coverage   76.92%   76.94%   +0.02%     
==========================================
  Files         225      225              
  Lines       16898    16893       -5     
==========================================
+ Hits        12998    12999       +1     
+ Misses       3068     3062       -6     
  Partials      832      832              
Flag Coverage Δ
ubuntu 76.85% <0.00%> (+0.01%) ⬆️
windows 76.74% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/run.go 72.65% <0.00%> (+1.45%) ⬆️
lib/netext/httpext/request.go 92.68% <0.00%> (-0.61%) ⬇️
metrics/value_type.go 68.75% <0.00%> (+6.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cmd/run.go Outdated Show resolved Hide resolved
mstoykov
mstoykov previously approved these changes Feb 25, 2023
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nitpick

cmd/run.go Outdated Show resolved Hide resolved
@na-- na-- force-pushed the fix-blocking-usage-report branch from e42160b to 15a2e28 Compare February 25, 2023 09:47
@na-- na-- merged commit 4463298 into master Feb 25, 2023
@na-- na-- deleted the fix-blocking-usage-report branch February 25, 2023 14:08
@na-- na-- mentioned this pull request Feb 27, 2023
na-- added a commit that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K6 Process Hangs After Summary Report
4 participants