Add to showcase how currently options is accessible everywhere #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is also true for anything defined in the main module exported or not. It is just much easier to showcase with options particularly. This IMO should never have been the case and should be fixed. Additionally ESM in practice will "fix" this as modules all have their own scopes. So it makes sense to maybe break this before we add ESM support
|
Partially previously discussed in #1430 |
|
closing this as I already opened a PR with the fix in which we can discuss the issue showcased here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is also true for anything defined in the main module exported or
not. It is just much easier to showcase with options particularly.
This IMO should never have been the case and should be fixed.
Additionally ESM in practice will "fix" this as modules all have their
own scopes. So it makes sense to maybe break this before we add ESM
support