Update gopkg.in/yaml.v3 to v3.0.1 from pre v3.0.0 #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update is an optimizations by making a custom AppendJSONString instead of using encoding/json. This is 2x faster for this particular thing.
A lot of optimizations including for zstd and flate, which are used in k6.
This has a bunch of small updates which are unlikely to matter for the case k6 uses this. The only reason to update is CVE-2022-28948. Which is only applicable for k6 when it's running its tc39 tests. So again no problem for our users.
olegbespalov
approved these changes
Jun 2, 2022
codebien
approved these changes
Jun 2, 2022
|
@mstoykov It seems you need to rebase, GitHub says 3 commits. |
|
@codebien it says that but then when you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a bunch of small updates which are unlikely to matter for the
case k6 uses this.
The only reason to update is CVE-2022-28948.
Which is only applicable for k6 when it's running its tc39 tests.
So again no problem for our users.