Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang CI version to 1.18 #2550

Merged
merged 1 commit into from
Jun 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# We are going to keep 1.16.x version until we move the build process to 1.18.x
go-version: [1.16.x, 1.17.x]
go-version: [1.17.x]
platform: [ubuntu-latest, windows-2019]
runs-on: ${{ matrix.platform }}
steps:
Expand Down Expand Up @@ -156,7 +155,7 @@ jobs:
uses: actions/setup-go@v2
with:
# We plan to move to 1.18.x after the release of the first patch.
go-version: 1.17.x
go-version: 1.18.x
- name: Install package builders
env:
GO111MODULE: 'off'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/arm-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: 1.17.x
go-version: 1.18.x
- name: Run tests
run: |
set -x
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dev-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
required: true
go_version:
description: 'Go version for building binaries'
default: '1.17.x'
default: '1.18.x'
required: true

defaults:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: 1.17.x
go-version: 1.18.x
- name: Check dependencies
run: |
go version
Expand All @@ -41,6 +41,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v2
with:
# up this to 1.18.x when we update teh version of golangci-lint to latest
go-version: 1.17.x
- name: Retrieve golangci-lint version
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tc39.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: 1.17.x
go-version: 1.18.x
- name: Run tests
run: |
set -x
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/xk6.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: 1.17.x
go-version: 1.18.x
- name: Install Go tip
if: matrix.go == 'tip'
run: |
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.17-alpine as builder
FROM golang:1.18-alpine as builder
WORKDIR $GOPATH/src/go.k6.io/k6
ADD . .
RUN apk --no-cache add git
Expand Down