Ensure rate sinks with no samples are formatted as 0% #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
force-pushed
the
fix/nan_on_rate_thresholds
branch
from
7d59319 to
18d6d36
Compare
|
Tests are currently failing because of chromium/badssl.com#504 |
olegbespalov
approved these changes
May 17, 2022
mstoykov
reviewed
May 18, 2022
Comment on lines
189
to
+195
| func (r RateSink) Format(t time.Duration) map[string]float64 { | ||
| return map[string]float64{"rate": float64(r.Trues) / float64(r.Total)} | ||
| var rate float64 | ||
| if r.Total > 0 { | ||
| rate = float64(r.Trues) / float64(r.Total) | ||
| } | ||
|
|
||
| return map[string]float64{"rate": rate} |
There was a problem hiding this comment.
This is also used for the API calls which likely is fine. But I kind of feel it might be better instead of this small fix to write bigger one where we actually remove Format and just write the logical for each of those 2 cases
see #2320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2540