Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unobserved parent metric when its submetric is in a threshold #2519

Merged
merged 1 commit into from
May 6, 2022
Merged

Fix unobserved parent metric when its submetric is in a threshold #2519

merged 1 commit into from
May 6, 2022

Conversation

na--
Copy link
Member

@na-- na-- commented May 6, 2022

This should fix #2518

@na-- na-- added this to the v0.38.2 milestone May 6, 2022
@na-- na-- requested review from oleiade and codebien May 6, 2022 12:40
oleiade
oleiade approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@oleiade oleiade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@na-- na-- mentioned this pull request May 6, 2022
Closed
@na-- na-- merged commit 7ab41a1 into master May 6, 2022
@na-- na-- deleted the fix-observed-parent-metrics branch May 6, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegbespalov olegbespalov olegbespalov approved these changes

@codebien codebien codebien approved these changes

@oleiade oleiade oleiade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.38.2
Development

Successfully merging this pull request may close these issues.

Sub-metrics without values are rendered below wrong main metric
4 participants
@na-- @oleiade @codebien @olegbespalov