Fix scenario information retrieval from externally-controlled executor #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously accessing some scenario state information using the externally-controlled executor would throw the error `getting scenario information in the init context is not supported`. This was because the context wasn't properly passed to the externallyControlledRunState. The test added here checks access for all executors, which would've caught this initially.
na--
approved these changes
Sep 10, 2021
codebien
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously accessing some scenario state information using the externally-controlled executor would throw the error
getting scenario information in the init context is not supported. This was because the context wasn't properly passed to theexternallyControlledRunState.The test added here checks access for all executors, which would've caught this initially.