Refactor ramping VUs executor #2124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2124 +/- ##
=========================================
Coverage ? 72.69%
=========================================
Files ? 182
Lines ? 14581
Branches ? 0
=========================================
Hits ? 10599
Misses ? 3338
Partials ? 644
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Thanks, I just skimmed this and it seems like a solid improvement! That said, all of the new methods end up having a ton of parameters and results, which is not ideal for comprehension. What we ended up doing in another executor (the k6/lib/executor/externally_controlled.go Lines 373 to 387 in 3994f1a |
|
Thanks! Also, thanks for pointing out the I have added a struct called |
imiric
previously approved these changes
Sep 23, 2021
There was a problem hiding this comment.
Nice job breaking down Run() 👏 handleVUs() is clean and the *HandlerStrategy functions are a nice touch and encapsulate the behavior nicely.
Just a minor meta nitpick: I would use a more descriptive commit message and PR description explaining what was done and why instead of just "refactor" :) E.g. "Split up RampingVUs.Run method ..." and maybe a small summary of the changes.
|
@inancgumus can you also provide some benchmark results from before and after the refactor |
|
|
@inancgumus seems okay, but in general run with Also please rebase on master as you now have conflicts after the metrics registry merge ... sorry about that :( |
|
Here are the benchmarks with |
mstoykov
reviewed
Sep 29, 2021
mstoykov
reviewed
Sep 29, 2021
mstoykov
requested changes
Sep 29, 2021
There was a problem hiding this comment.
LGTM in general. I have some naming ... considerations and some code golfing (that isn't really necessary and might be worse for readability).
The biggest "request change" is actually adding a test for gracefulShutdown and rampingVUs given the comment that removing the support for it doesn't break tests :)
RampingVUs.Run method was complex and this refactors it by adding
rampingVUsRunState to share run state between functions used by
the Run method.
+ Makes the Run method easier to read and understand
+ Makes it explicit which Goroutines are being fired in the Run
+ Separates responsibilities to other parts like:
+ rampingVUsRunState and its methods.
+ Moves trackProgress Goroutine from the makeProgressFn
to the Run method
+ Makes initializeVUs to only handle initializing GRs
+ Uses two strategy functions to make them reusable
and clearer. handleVUs and handleRemainingVUs use them.
+ Makes the handleVUs algorithm easier to understand and
manage.
`go get` was failing on Go tip.
Closed
3 tasks
imiric
reviewed
Oct 1, 2021
imiric
reviewed
Oct 1, 2021
imiric
reviewed
Oct 4, 2021
Co-authored-by: Ivan Mirić <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored Ramping VUs executor—a little bit. This is the first step as I'm learning about the system. I hope this refactoring makes sense.