Support non-TLS HTTP/2 (i.e. H2C) #1968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Http2.0 non-tls patch
na--
requested changes
Apr 19, 2021
There was a problem hiding this comment.
As I explained in the issue, we won't be able to merge this because it likely breaks k6 for every other use case...
Comment on lines
199
to
+200
| _ = http2.ConfigureTransport(transport) | ||
| http2Transport, err := http2.ConfigureTransports(transport) |
There was a problem hiding this comment.
You shouldn't call both http2.ConfigureTransport() and http2.ConfigureTransports(), they do the same thing.
Suggested change
| _ = http2.ConfigureTransport(transport) | |
| http2Transport, err := http2.ConfigureTransports(transport) | |
| http2Transport, err := http2.ConfigureTransports(transport) |
Also, you may have to pass the http2Transport as the VU.Transport below, though I'm not completely sure about that... 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Http2.0 non-tls patch
Pls help to check if we did sth wrong, thx!
(edited by @na-- - this is the relevant issue: #970)