-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update other dependencies #1940
Conversation
This has some fixes for unmarshalling which we barely use, it is mostly done so we are up to date.
…1.3.0 There are some bugfixes including some panics in rare cases that are now fixed.
…eb68cc467c There are a lot of optimizations especially in less allocations. Also it drops a dependency which means this is actually less code in the k6 repo 🎉
no tagged releases but we go from commit from the year 2015 to one from 2019 Added an additional method to get number of pooled buffers and ByteSlicePool
The only change is a change to it's CI
This mostly add logging through functions and drops a dependancy by just embeding the relevant parts in logrus.
This adds some additional helpers most interesting of which support for the new errors and friends. This also adds v3 of gopkg.in/yaml as a dependency but this likely will happen from some other dependency either way
There are some additional syntax supports. The update github.com/tidwall/pretty is used in `convert/har` and stopped adding spaces after commas in multi line arrays which required the changes to `testdata/example.js`
Please go commit by commit as they explain what is changed and I prefer to not copy it ;) |
Codecov Report
@@ Coverage Diff @@
## master #1940 +/- ##
=======================================
Coverage 71.23% 71.24%
=======================================
Files 183 183
Lines 14336 14336
=======================================
+ Hits 10212 10213 +1
Misses 3484 3484
+ Partials 640 639 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Adds an additional method ProcessChallengeWithHash which gets a hash instead of user and password.
…v1.7.2 This is nearly 2 years of updates, most of which seem to be performance related.
The only remaining dependencies that should be updated at all from #1933 are:
There were no updates for:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds gopkg.in/yaml.v3
, while keeping gopkg.in/yaml.v2
. I think we can drop the latter with a minor change in k6:
$ go mod why 'gopkg.in/yaml.v3'
# gopkg.in/yaml.v3
github.com/loadimpact/k6/lib/testutils/httpmultibin
github.com/stretchr/testify/assert
gopkg.in/yaml.v3
$ go mod why 'gopkg.in/yaml.v2'
# gopkg.in/yaml.v2
github.com/loadimpact/k6/ui
gopkg.in/yaml.v2
Unfortunately - not @na-- , as it's also used in Also even if we could I prefer to do it in a separate PR, where I will drop the direct uses by k6 and also the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golang/go#41305 ... 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞 A lot of new LOCs, but it seems unavoidable.
Nice job reviewing each update and detailing it in separate commits! 👏
This updates the majority of the k6 dependencies that we intended to update from #1933.
The biggest size increases are from yaml.v3 addition, compression algorithms, and testify additions.