Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't always set the trail.Failed to true due to how SetValid works #1907

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

mstoykov
Copy link
Contributor

No description provided.

@mstoykov
Copy link
Contributor Author

A cautionary tale on RTFM ... https://pkg.go.dev/gopkg.in/guregu/null.v3#Bool.SetValid

@mstoykov mstoykov requested review from na-- and imiric March 15, 2021 15:36
na--
na-- previously approved these changes Mar 15, 2021
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though if possible, can you check this in some test?

@mstoykov mstoykov linked an issue Mar 15, 2021 that may be closed by this pull request
imiric
imiric previously approved these changes Mar 15, 2021
@na-- na-- added this to the v0.31.1 milestone Mar 15, 2021
@mstoykov mstoykov dismissed stale reviews from imiric and na-- via 1885779 March 15, 2021 16:38
@codecov-io
Copy link

codecov-io commented Mar 15, 2021

Codecov Report

Merging #1907 (cb9d859) into master (f0169c0) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1907      +/-   ##
==========================================
- Coverage   71.21%   71.17%   -0.04%     
==========================================
  Files         183      183              
  Lines       14325    14337      +12     
==========================================
+ Hits        10202    10205       +3     
- Misses       3497     3504       +7     
- Partials      626      628       +2     
Flag Coverage Δ
ubuntu 71.17% <100.00%> (+0.01%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/netext/httpext/transport.go 97.14% <100.00%> (ø)
js/common/initenv.go 86.66% <0.00%> (-13.34%) ⬇️
js/initcontext.go 90.10% <0.00%> (-2.20%) ⬇️
lib/executor/vu_handle.go 93.33% <0.00%> (-1.91%) ⬇️
core/engine.go 85.13% <0.00%> (-1.81%) ⬇️
js/runner.go 80.86% <0.00%> (-0.58%) ⬇️
js/modules/k6/http/http.go 100.00% <0.00%> (ø)
cmd/ui_windows.go
output/cloud/metrics_client.go 80.76% <0.00%> (ø)
output/cloud/output.go 81.28% <0.00%> (+0.65%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0169c0...cb9d859. Read the comment docs.

@mstoykov mstoykov force-pushed the fixTrailHTTPReqFailedPropagation branch from 1885779 to cb9d859 Compare March 16, 2021 08:05
na--
na-- previously approved these changes Mar 16, 2021
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it might be simpler to also add the v0.31.1 release notes in this same PR

imiric
imiric previously approved these changes Mar 16, 2021
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@na-- I'd leave the release notes for a separate PR.

lib/netext/httpext/request_test.go Outdated Show resolved Hide resolved
@mstoykov mstoykov dismissed stale reviews from imiric and na-- via 0d7840b March 16, 2021 08:48
@mstoykov mstoykov force-pushed the fixTrailHTTPReqFailedPropagation branch from cb9d859 to 0d7840b Compare March 16, 2021 08:48
@mstoykov mstoykov merged commit 0d7840b into master Mar 17, 2021
@na-- na-- deleted the fixTrailHTTPReqFailedPropagation branch May 11, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http_req_failed is always true when being send to the cloud
4 participants