-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't always set the trail.Failed to true due to how SetValid works #1907
Conversation
A cautionary tale on RTFM ... https://pkg.go.dev/gopkg.in/guregu/null.v3#Bool.SetValid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though if possible, can you check this in some test?
Codecov Report
@@ Coverage Diff @@
## master #1907 +/- ##
==========================================
- Coverage 71.21% 71.17% -0.04%
==========================================
Files 183 183
Lines 14325 14337 +12
==========================================
+ Hits 10202 10205 +3
- Misses 3497 3504 +7
- Partials 626 628 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
1885779
to
cb9d859
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it might be simpler to also add the v0.31.1 release notes in this same PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@na-- I'd leave the release notes for a separate PR.
cb9d859
to
0d7840b
Compare
No description provided.