Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.31.0 #1884

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Release v0.31.0 #1884

merged 2 commits into from
Mar 11, 2021

Conversation

imiric
Copy link
Contributor

@imiric imiric commented Mar 5, 2021

No description provided.

@imiric imiric requested review from mstoykov and na-- March 5, 2021 10:21
release notes/v0.31.0.md Outdated Show resolved Hide resolved
release notes/v0.31.0.md Outdated Show resolved Hide resolved
release notes/v0.31.0.md Outdated Show resolved Hide resolved
release notes/v0.31.0.md Outdated Show resolved Hide resolved
release notes/v0.31.0.md Outdated Show resolved Hide resolved
@na-- na-- added this to the v0.31.0 milestone Mar 5, 2021
release notes/v0.31.0.md Outdated Show resolved Hide resolved
imiric pushed a commit that referenced this pull request Mar 5, 2021
imiric pushed a commit that referenced this pull request Mar 5, 2021
imiric pushed a commit that referenced this pull request Mar 5, 2021
@codecov-io
Copy link

codecov-io commented Mar 5, 2021

Codecov Report

Merging #1884 (a08771f) into master (a2ba970) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1884      +/-   ##
==========================================
- Coverage   71.20%   71.16%   -0.05%     
==========================================
  Files         183      183              
  Lines       14325    14325              
==========================================
- Hits        10200    10194       -6     
- Misses       3499     3505       +6     
  Partials      626      626              
Flag Coverage Δ
ubuntu 71.13% <ø> (-0.02%) ⬇️
windows 70.76% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/consts/consts.go 0.00% <ø> (ø)
core/engine.go 85.13% <0.00%> (-1.81%) ⬇️
js/runner.go 80.86% <0.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2ba970...d08f642. Read the comment docs.

imiric pushed a commit that referenced this pull request Mar 5, 2021
imiric pushed a commit that referenced this pull request Mar 5, 2021
@imiric imiric requested review from mstoykov and na-- March 5, 2021 16:28
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other minor general nitpick. The PR links in brackets are after the dot, e.g.

  • JS: Also because of goja improvements, some unused Babel plugins were disabled which should have minor performance benefits as well. (#1822)

instead of before the dot, like in the v0.30.0 release notes, like this:

  • JS: Also because of goja improvements, some unused Babel plugins were disabled which should have minor performance benefits as well (#1822).

release notes/v0.31.0.md Outdated Show resolved Hide resolved
release notes/v0.31.0.md Outdated Show resolved Hide resolved
release notes/v0.31.0.md Outdated Show resolved Hide resolved
release notes/v0.31.0.md Outdated Show resolved Hide resolved
release notes/v0.31.0.md Outdated Show resolved Hide resolved
release notes/v0.31.0.md Show resolved Hide resolved
release notes/v0.31.0.md Outdated Show resolved Hide resolved
release notes/v0.31.0.md Outdated Show resolved Hide resolved
@imiric
Copy link
Contributor Author

imiric commented Mar 9, 2021

@na--:

The PR links in brackets are after the dot

I did it this way because some items have more than one sentence explaining them, so it wouldn't make sense to place the link inside the first sentence nor the last. So placing it at the end is consistent for all cases.

release notes/v0.31.0.md Outdated Show resolved Hide resolved
release notes/v0.31.0.md Outdated Show resolved Hide resolved
Copy link

@nicolevanderhoeven nicolevanderhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Made some minor suggestions, but nothing further from me! I'll start working on the video. :)

release notes/v0.31.0.md Outdated Show resolved Hide resolved
release notes/v0.31.0.md Outdated Show resolved Hide resolved
release notes/v0.31.0.md Outdated Show resolved Hide resolved
release notes/v0.31.0.md Outdated Show resolved Hide resolved
release notes/v0.31.0.md Outdated Show resolved Hide resolved
na--
na-- previously approved these changes Mar 11, 2021
Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides that last minor inline nitpick. Please rebase and squash the PR on top of the latest master.

@imiric
Copy link
Contributor Author

imiric commented Mar 11, 2021

squash the PR

I squashed the release notes changes, but will keep the version bump in a separate commit, and rebase both commits on master.

@imiric imiric changed the title Add v0.31.0 release notes Release v0.31.0 Mar 11, 2021
@imiric imiric merged commit f0169c0 into master Mar 11, 2021
@imiric imiric deleted the release/v0.31.0-notes branch March 11, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants