-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.31.0 #1884
Release v0.31.0 #1884
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1884 +/- ##
==========================================
- Coverage 71.20% 71.16% -0.05%
==========================================
Files 183 183
Lines 14325 14325
==========================================
- Hits 10200 10194 -6
- Misses 3499 3505 +6
Partials 626 626
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other minor general nitpick. The PR links in brackets are after the dot, e.g.
- JS: Also because of goja improvements, some unused Babel plugins were disabled which should have minor performance benefits as well. (#1822)
instead of before the dot, like in the v0.30.0 release notes, like this:
- JS: Also because of goja improvements, some unused Babel plugins were disabled which should have minor performance benefits as well (#1822).
I did it this way because some items have more than one sentence explaining them, so it wouldn't make sense to place the link inside the first sentence nor the last. So placing it at the end is consistent for all cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Made some minor suggestions, but nothing further from me! I'll start working on the video. :)
9794479
to
486f493
Compare
3c34408
to
9a392b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides that last minor inline nitpick. Please rebase and squash the PR on top of the latest master
.
d08f642
to
d13c1ab
Compare
I squashed the release notes changes, but will keep the version bump in a separate commit, and rebase both commits on |
No description provided.