-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require cloud scripts to always have a name #1870
Conversation
Codecov Report
@@ Coverage Diff @@
## output-refactoring-2 #1870 +/- ##
========================================================
+ Coverage 70.76% 70.83% +0.07%
========================================================
Files 181 182 +1
Lines 14163 14167 +4
========================================================
+ Hits 10022 10035 +13
+ Misses 3518 3512 -6
+ Partials 623 620 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I prefer we check the error for the more important part of the message ;)
ba40f59
to
ab81f18
Compare
ab81f18
to
e77e159
Compare
The base branch was changed.
e77e159
to
88f3519
Compare
This fixes #923 and was originally part of #1869, but it makes more sense as a separate PR, so I split it apart.