Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require cloud scripts to always have a name #1870

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Conversation

na--
Copy link
Member

@na-- na-- commented Feb 23, 2021

This fixes #923 and was originally part of #1869, but it makes more sense as a separate PR, so I split it apart.

@na-- na-- requested review from mstoykov and imiric February 23, 2021 12:53
@na-- na-- added this to the v0.31.0 milestone Feb 23, 2021
@codecov-io
Copy link

codecov-io commented Feb 23, 2021

Codecov Report

Merging #1870 (e77e159) into output-refactoring-2 (5e41f5e) will increase coverage by 0.07%.
The diff coverage is 80.00%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           output-refactoring-2    #1870      +/-   ##
========================================================
+ Coverage                 70.76%   70.83%   +0.07%     
========================================================
  Files                       181      182       +1     
  Lines                     14163    14167       +4     
========================================================
+ Hits                      10022    10035      +13     
+ Misses                     3518     3512       -6     
+ Partials                    623      620       -3     
Flag Coverage Δ
ubuntu 70.79% <80.00%> (+0.03%) ⬆️
windows 70.43% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stats/cloud/collector.go 81.92% <80.00%> (+0.15%) ⬆️
cmd/ui_windows.go 0.00% <0.00%> (ø)
lib/executor/vu_handle.go 95.23% <0.00%> (+1.90%) ⬆️
js/initcontext.go 92.30% <0.00%> (+2.19%) ⬆️
lib/executors.go 93.10% <0.00%> (+2.29%) ⬆️
cloudapi/config.go 44.15% <0.00%> (+2.59%) ⬆️
js/common/initenv.go 100.00% <0.00%> (+13.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e41f5e...e77e159. Read the comment docs.

Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I prefer we check the error for the more important part of the message ;)

stats/cloud/collector_test.go Outdated Show resolved Hide resolved
mstoykov
mstoykov previously approved these changes Feb 23, 2021
@na-- na-- force-pushed the fix-cloud-script-name branch from ba40f59 to ab81f18 Compare February 25, 2021 06:56
imiric
imiric previously approved these changes Feb 25, 2021
@na-- na-- force-pushed the fix-cloud-script-name branch from ab81f18 to e77e159 Compare February 25, 2021 14:06
Base automatically changed from output-refactoring-2 to master February 26, 2021 13:21
@na-- na-- dismissed stale reviews from imiric and mstoykov February 26, 2021 13:21

The base branch was changed.

@na-- na-- requested review from mstoykov and imiric February 26, 2021 13:25
@na-- na-- force-pushed the fix-cloud-script-name branch from e77e159 to 88f3519 Compare February 26, 2021 13:32
@na-- na-- merged commit 82cab8b into master Feb 26, 2021
@na-- na-- deleted the fix-cloud-script-name branch February 26, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User-friendly error when test name is not set in cloud execution
4 participants