Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global as in nodejs for backwards compatibility #1845

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Feb 8, 2021

this is only being added to the "extented" compatibility-mode as it was
being provided by core-js before it was dropped.

this is only being added to the "extented" compatibility-mode as it was
being provided by core-js before it was dropped.
imiric
imiric previously approved these changes Feb 8, 2021
Copy link
Contributor

@imiric imiric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a small test for it?

@codecov-io
Copy link

Codecov Report

Merging #1845 (b3214e4) into master (c6dec36) will decrease coverage by 1.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1845      +/-   ##
==========================================
- Coverage   71.60%   70.13%   -1.47%     
==========================================
  Files         179      178       -1     
  Lines       13928    13929       +1     
==========================================
- Hits         9973     9769     -204     
- Misses       3323     3524     +201     
- Partials      632      636       +4     
Flag Coverage Δ
ubuntu ?
windows 70.13% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/bundle.go 91.94% <100.00%> (+0.10%) ⬆️
js/modules/k6/http/cookiejar.go 15.00% <0.00%> (-55.00%) ⬇️
lib/netext/tls.go 18.00% <0.00%> (-30.00%) ⬇️
lib/testutils/httpmultibin/httpmultibin.go 66.29% <0.00%> (-23.60%) ⬇️
js/modules/k6/http/request.go 59.21% <0.00%> (-20.93%) ⬇️
loader/readsource.go 65.38% <0.00%> (-19.24%) ⬇️
lib/netext/httpext/request.go 82.53% <0.00%> (-14.46%) ⬇️
js/modules/k6/http/http_url.go 75.00% <0.00%> (-12.50%) ⬇️
lib/netext/httpext/digest_transport.go 68.42% <0.00%> (-10.53%) ⬇️
stats/statsd/common/collector.go 73.49% <0.00%> (-8.44%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6dec36...b3214e4. Read the comment docs.

@mstoykov mstoykov merged commit a379c37 into master Feb 8, 2021
@mstoykov mstoykov deleted the addGlobal branch February 8, 2021 20:58
andriisoldatenko pushed a commit to andriisoldatenko/k6 that referenced this pull request Feb 9, 2021
this is only being added to the "extented" compatibility-mode as it was
being provided by core-js before it was dropped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants