Add/move SharedArray tests to it's module #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
commented
Jan 12, 2021
Comment on lines
+103
to
+115
| initEnv := &common.InitEnvironment{ | ||
| SharedObjects: common.NewSharedObjects(), | ||
| } | ||
| rt, err := newConfiguredRuntime(initEnv) | ||
| require.NoError(t, err) | ||
| _, err = rt.RunString(makeArrayScript) | ||
| require.NoError(t, err) | ||
|
|
||
| // create another Runtime with new ctx but keep the initEnv | ||
| rt, err = newConfiguredRuntime(initEnv) | ||
| require.NoError(t, err) | ||
| _, err = rt.RunString(makeArrayScript) | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
Couldn't figure out what to name this block of code ... so I didn't move it to a function 🤷
Codecov Report
@@ Coverage Diff @@
## master #1795 +/- ##
==========================================
- Coverage 71.44% 71.41% -0.03%
==========================================
Files 180 180
Lines 13839 13839
==========================================
- Hits 9887 9883 -4
- Misses 3328 3332 +4
Partials 624 624
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
imiric
suggested changes
Jan 12, 2021
Co-authored-by: Ivan Mirić <[email protected]>
imiric
approved these changes
Jan 12, 2021
na--
approved these changes
Jan 13, 2021
salem84
pushed a commit
to salem84/k6
that referenced
this pull request
Feb 3, 2021
Co-authored-by: Ivan Mirić <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.