Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/adding event hubs output plugin #1755
feature/adding event hubs output plugin #1755
Changes from 8 commits
d0673f0
5089e8b
2932a14
cd1cda5
a829d96
86492c2
5936e48
8b219fd
d03022b
7cbee51
8e132a8
c9ad512
117b7d9
3535731
7c6b9ee
88e422d
42cf0e8
df5615d
f555efb
0bf66ab
ee9e408
51a5df4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update all documentation comments for this collector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not clear what you're testing here...
SampleToRow()
is a CSV collector function, and here you're comparing two structs for equality, so I don't see how it could fail. 😕In this file I would expect to see tests of the
Collector
methods. If you can't start a mock server to test against, consider abstracting away thec.client
calls, e.g. by passing some interface you can mock out in the tests.