Fix break line after password input (#1703) #1742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
na--
requested changes
Nov 30, 2020
There was a problem hiding this comment.
Thanks for making this PR, however the PasswordField doesn't seem to be the right place to make this change...
See how the ui.Form works, the Field objects don't write things, only the Form does: https://github.com/loadimpact/k6/blob/40979fd751999415e6f00de16ce4fedd22a838aa/ui/form.go#L30-L48
And it has an io.Writer injected, so we certainly should try to avoid using a global fmt.Print() call and use that writer instead (e.g. use fmt.Fprint(w, "\n") instead).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1703