-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catching of VU panics #1697
catching of VU panics #1697
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1697 +/- ##
==========================================
+ Coverage 72.31% 72.33% +0.01%
==========================================
Files 176 176
Lines 13536 13538 +2
==========================================
+ Hits 9789 9793 +4
+ Misses 3134 3132 -2
Partials 613 613
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
f4ec572
to
d066deb
Compare
This supersedes #1665 |
For the record this code resets the stack and other stuff to the previous values if there is a panic (even if the code below panics again) to what it was before a function was called and calling a Callable basically calls this. So unless this code panics in the middle the state of the Runtime should be "somewhat" restored to the previous one. Obviously any changes to global variables will stick. And if the panic in somehow has gotten the non goja stack but for example some internal to k6 state in a bad state that will lead to problems. I can't figure out a way to break the goja stack in my first few tries and ... I can't remember anything in k6 that will have such a problem so it seems safe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.