-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/block hostname #1666
Feature/block hostname #1666
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1666 +/- ##
==========================================
- Coverage 72.19% 72.05% -0.15%
==========================================
Files 166 167 +1
Lines 12787 12876 +89
==========================================
+ Hits 9232 9278 +46
- Misses 3005 3035 +30
- Partials 550 563 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fdd49fb
to
3cb4151
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't spot anything that @imiric hadn't already commented on, so LGTM besides these comments
Co-authored-by: Ivan Mirić <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This supersedes #1532