Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (Un)Marshal functions to stats.TagSet #1604

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Conversation

mstoykov
Copy link
Contributor

Also, sort the keys before marshaling them with SystemTagSet for
consistent output.

fixes #1602

Also, sort the keys before marshaling them with SystemTagSet for
consistent output.

fixes #1602
imiric
imiric previously approved these changes Aug 24, 2020
stats/system_tag.go Outdated Show resolved Hide resolved
Co-authored-by: Ivan Mirić <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2020

Codecov Report

Merging #1604 into master will decrease coverage by 0.02%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1604      +/-   ##
==========================================
- Coverage   74.87%   74.85%   -0.03%     
==========================================
  Files         164      164              
  Lines       14035    14062      +27     
==========================================
+ Hits        10509    10526      +17     
- Misses       2994     3003       +9     
- Partials      532      533       +1     
Impacted Files Coverage Δ
stats/system_tag.go 85.00% <92.85%> (+3.86%) ⬆️
lib/testutils/minirunner/minirunner.go 78.57% <0.00%> (-3.58%) ⬇️
lib/executor/vu_handle.go 93.69% <0.00%> (-1.81%) ⬇️
js/runner.go 83.04% <0.00%> (-0.70%) ⬇️
stats/cloud/collector.go 78.74% <0.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ab11c0...97c798d. Read the comment docs.

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@na-- na-- added this to the v0.28.0 milestone Sep 2, 2020
@mstoykov mstoykov merged commit c412fc7 into master Sep 2, 2020
@mstoykov mstoykov deleted the fixTagSetMarshalling branch September 2, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K6_DATADOG_TAG_BLACKLIST not functional
4 participants