Fix UI panic and login errors on mintty/Windows #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na--
reviewed
Jul 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #1561 +/- ##
==========================================
- Coverage 77.18% 77.09% -0.10%
==========================================
Files 162 162
Lines 13172 13188 +16
==========================================
Hits 10167 10167
- Misses 2485 2501 +16
Partials 520 520
Continue to review full report at Codecov.
|
imiric
commented
Jul 16, 2020
| if !errTermGetSize { | ||
| // More responsive progress bar resizing on platforms with SIGWINCH (*nix) | ||
| termWidth, _, err = terminal.GetSize(fd) | ||
| if err != nil { |
There was a problem hiding this comment.
Maybe we can ignore checking this err if it didn't fail the first time?
mstoykov
reviewed
Jul 16, 2020
This falls back to plain text input which will echo the password back, but there doesn't seem to be a way around that. :-/
imiric
force-pushed
the
fix/1559-mintty-panic
branch
from
7f6a17a to
1e4b958
Compare
imiric
changed the title
mstoykov
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1559
Confirmed working on the latest Git Bash (2.27.0) and mintty 3.1.6 on Windows 10 x64 1903.
The "error getting terminal size" warning will still be shown and the progressbars will be static, but at least it doesn't panic 😅