Copy __ENV so that 2 VUs don't share the same one #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as in #799(which was about the same issue with setup data), we don't actually have problems with a VU seeing changes from previous iterations. It will be too expensive to constantly copy, it won't panic and there are no issues with distributed execution.
mstoykov
force-pushed
the
fixENVBeingShared
branch
from
33513be to
97d1ea8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1329 +/- ##
==========================================
- Coverage 75.44% 75.43% -0.02%
==========================================
Files 150 150
Lines 10885 10888 +3
==========================================
+ Hits 8212 8213 +1
- Misses 2207 2209 +2
Partials 466 466
Continue to review full report at Codecov.
|
na--
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as in #799(which was about the same issue with setup data), we
don't actually have problems with a VU seeing changes from
previous iterations. It will be too expensive to constantly copy, it
won't panic and there are no issues with distributed execution.
fixes #1328