Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "cmd: mark convert command as deprecated" #1268

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

mstoykov
Copy link
Contributor

This reverts commit 030d37d.

@mstoykov mstoykov requested review from imiric, na-- and cuonglm December 11, 2019 09:36
@na--
Copy link
Member

na-- commented Dec 11, 2019

For posterity, the rationale behind this decision is that the new external HAR converter still doesn't have full feature parity with the current built-in k6 HAR converter.

@codecov-io
Copy link

codecov-io commented Dec 11, 2019

Codecov Report

Merging #1268 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
+ Coverage   75.42%   75.43%   +0.01%     
==========================================
  Files         150      150              
  Lines       10883    10883              
==========================================
+ Hits         8208     8210       +2     
+ Misses       2209     2207       -2     
  Partials      466      466
Impacted Files Coverage Δ
cmd/convert.go 46.15% <ø> (ø) ⬆️
stats/cloud/collector.go 77.6% <0%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3de91a1...1faf3f6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants