Add a mutex to js.VU to prevent multiple asynchrnous calls to RunOnce #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix #867. This is not ... a great fix in the sense that while doing it I found out we are also asynchrnously touch VU.Runtime which should also not happen and the currently added mutex should probably be locked in most other functions, but this should fix the immediate problems and the other should be fixed in a more ... complete redesign :)
na--
reviewed
Nov 25, 2019
| @@ -534,6 +535,56 @@ func TestVURunInterrupt(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestVURunInterruptDoesntPanic(t *testing.T) { | |||
| //TODO: figure out why interrupt sometimes fails... data race in goja? | |||
There was a problem hiding this comment.
I think the issue would disappear after we update goja to include this fix: dop251/goja@f95411d
There was a problem hiding this comment.
i think we even have an issue for this ... maybe we should upgrade goja ... soon ™️
na--
approved these changes
Nov 25, 2019
cuonglm
reviewed
Nov 25, 2019
imiric
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #867.
This is not ... a great fix in the sense that while doing it I found out
we are also asynchrnously touch VU.Runtime which should also not happen
and the currently added mutex should probably be locked in most other
functions, but this should fix the immediate problems and the other
should be fixed in a more ... complete redesign :)